On Mon, 25 Aug 2014, Peter Chen wrote: > Hi Felipe & Alan, > > It is the follow-up for: > http://www.spinics.net/lists/linux-usb/msg112193.html > > This patchset adds reset API at usb_gadget_driver, the UDC driver > can call it at bus_reset handler instead of calling disconnect. > The benefits of this patchset are: > - We can let the gadget driver do different things for bus reset. > and host is disconnected, eg, whether pull down dp or not. > - Match kernel doc for disconnect API, it says it is invoked > "when the host is disconnected". > - Will be more match for the real things the gadget driver > does for connect and disconnect, when we introduce connect API later. > > The reason for I mark RFC is I don't add the modification for mass > UDC driver changes, if you consider this patchset is ok, I will > add them without RFC later.
This looks good. In patches 2, 4, and 5, shouldn't you call usb_gadget_disconnect() _before_ the gadget driver's original disconnect handler, instead of _after_? That's how we do it now. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
