On Thu, 2014-09-04 at 13:36 +0200, Johan Hovold wrote:
> On Thu, Sep 04, 2014 at 12:44:37PM +0200, Oliver Neukum wrote:
> > Hi,
> >
> > I also got a problem with such a device and I took your patch
> > and applied it to this device. What do you think? The only
> > substantial change I made was not counting unrequested input
> > for autosuspend.
>
> Ah, good to know there are more devices that need this quirk.
Actually, I'd prefer you to be the only one. ;-)
But shared misery is better than single misery.
> I got side-tracked with other stuff, but I should be able to submit the
> patch this week (just want to look through it once more first).
Good.
> Not sure the mark-last-busy needs to be moved, though. The device has
> already been woken up, and might as well stay unsuspended for a while
> longer should further events occur.
Why? Remote wakeup will be disabled. It would be a waste of power.
[..]
> > @@ -79,6 +79,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
> > HID_QUIRK_NO_INIT_REPORTS },
> > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET
> > },
> > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET
> > },
> > + { USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN,
> > HID_QUIRK_ALWAYS_POLL },
>
> You'd want to use USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE here, or?
Yes. Thank you.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
