On Thu, 9 Oct 2014, Michael Grzeschik wrote:

> This patch adds an hub_control override to toggle the PORT_POWER
> by the registered regulator. That is needed when an external
> GPIO is used instead of the default PORT_POWER bit.

I don't think this is such a good approach.  There are places in 
ehci-hcd where port power is toggled directly, without going through 
ehci_hub_control().  For example, see ehci_turn_off_all_ports().

You should do what I recommended earlier: Add routines to ehci-hcd 
specifically for turning port power on or off, and then use those 
routines every place the power setting gets changed.  Then those 
routines can call a platform-specific override, if needed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to