On Fri, 17 Oct 2014 15:22:02 -0400 (EDT)
Alan Stern <[email protected]> wrote:

> On Fri, 17 Oct 2014, Mark Knibbs wrote:
>
> > ...
> > It looks like the 5000 timeout in usb_stor_euscsi_init() should be replaced
> > by 5*HZ then?
>
> Yes, it does look wrong.  There may be other places that also call the 
> function with a timeout value in ms rather than jiffies...

The only other function that I could see with that problem is
usb_stor_huawei_e220_init(), also in drivers/usb/storage/initializers.c

It uses 1000 for timeout, which presumably should be HZ (or 1*HZ to make
things clearer?).

Any idea why the two similar functions have different ways of specifying
the timeout?


Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to