Hi Varka,

On 31/10/2014 02:14, Varka Bhadram wrote:
> From: Varka Bhadram <varkabhad...@gmail.com>
> 
> Sanity check on resource happening with devm_ioremap_resource().



Reviewed-by: Gregory CLEMENT <gregory.clem...@free-electrons.com>


Thanks,

Gregory


> 
> Signed-off-by: Varka Bhadram <var...@cdac.in>
> Acked-by: Alan Stern <st...@rowland.harvard.edu>
> ---
>  drivers/usb/host/ehci-orion.c |   10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index 22e15ca..36b4657 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -175,15 +175,6 @@ static int ehci_orion_drv_probe(struct platform_device 
> *pdev)
>               goto err;
>       }
>  
> -     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -     if (!res) {
> -             dev_err(&pdev->dev,
> -                     "Found HC with no register addr. Check %s setup!\n",
> -                     dev_name(&pdev->dev));
> -             err = -ENODEV;
> -             goto err;
> -     }
> -
>       /*
>        * Right now device-tree probed devices don't get dma_mask
>        * set. Since shared usb code relies on it, set it here for
> @@ -193,6 +184,7 @@ static int ehci_orion_drv_probe(struct platform_device 
> *pdev)
>       if (err)
>               goto err;
>  
> +     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>       regs = devm_ioremap_resource(&pdev->dev, res);
>       if (IS_ERR(regs)) {
>               err = PTR_ERR(regs);
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to