Hi, > -----Original Message----- > From: Kaukab, Yousaf > Sent: Thursday, December 18, 2014 7:54 PM > To: [email protected]; [email protected] > Cc: Herrero, Gregory; [email protected]; Kaukab, Yousaf > Subject: [PATCH 17/29] usb: dwc2: gadget: manage ep0 state in software > > Manage ep0 state in software to add handling of status OUT stage. > Just toggling hsotg->setup in s3c_hsotg_handle_outdone leaves it in wrong > state in 2-stage control transfers. > Moreover, there is no need to handle SetupDone as requests can be complete > on XferCmpl of status stage. > > Signed-off-by: Mian Yousaf Kaukab <[email protected]> > --- > drivers/usb/dwc2/core.h | 13 +++- > drivers/usb/dwc2/gadget.c | 151 > ++++++++++++++++++++++------------------------ > 2 files changed, 83 insertions(+), 81 deletions(-) [...] > @@ -1533,8 +1517,7 @@ static void s3c_hsotg_handle_rx(struct dwc2_hsotg > *hsotg) > "SetupDone (Frame=0x%08x, > DOPEPCTL=0x%08x)\n", > s3c_hsotg_read_frameno(hsotg), > readl(hsotg->regs + DOEPCTL(0))); > - > - s3c_hsotg_handle_outdone(hsotg, epnum, true); > + /* XferCmpl is used to complete the transfers */ > break;
This comment is incorrect. XferCmpl should read OutDone. BR, Yousaf -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
