W dniu 14.01.2015 o 22:02, Dan Carpenter pisze:
"num" is a u32 so "(num > 0xFFFFFFFF)" is never true.  Also the range
is already checked in kstrtou32().

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>


Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com>

diff --git a/drivers/usb/gadget/function/uvc_configfs.c 
b/drivers/usb/gadget/function/uvc_configfs.c
index 2bd0688..738d68f 100644
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -1156,8 +1156,6 @@ static inline int __uvcg_fill_frm_intrv(char *buf, void 
*priv)
        ret = kstrtou32(buf, 0, &num);
        if (ret)
                return ret;
-       if (num > 0xFFFFFFFF)
-               return -EINVAL;

        interv = priv;
        **interv = cpu_to_le32(num);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to