Hi David, On Thu, Jan 22, 2015 at 09:57:04AM +0000, David Binderman wrote: > [linux-3.19-rc5/drivers/usb/phy/phy-msm-usb.c:1109] -> > [linux-3.19-rc5/drivers/usb/phy/phy-msm-usb.c:1112]: (warning) Variable > 'chg_state' is reassigned a value before the old one has been used. 'break;' > missing? > > Source code is > > case USB_CHG_STATE_SECONDARY_DONE: > motg->chg_state = USB_CHG_STATE_DETECTED; > case USB_CHG_STATE_DETECTED: > > Suggest code rework.
As it looks now, it looks like the fall-through may simply be intentional, as there isn't any additional handling to be done. So the case statement can simply be omitted entirely. I'll check with the original author internally and send a patch. Thanks, Jack -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
