----- Mail original ----- De: "Fabio Estevam" <[email protected]> À: "Robert Jarzmik" <[email protected]> Cc: "Felipe Balbi" <[email protected]>, "Linus Walleij" <[email protected]>, "Philipp Zabel" <[email protected]>, "USB list" <[email protected]> Envoyé: Mardi 27 Janvier 2015 10:40:35 Objet: Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc > - nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios"); > + nop->gpiod_reset = devm_gpiod_get_optional(dev, > "reset-gpios");
> According to Documentation/gpio/board.txt: > "GPIOs mappings are defined in the consumer device's node, in a > property named <function>-gpios" > so this should be: > nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset"); Ah you're right, I see it now ... in of_find_gpio(), the match is done on "%s-%s", where the first one is the string in devm_gpiod_get(), and the second one is either "gpio" or "gpios" ... I'll amend my patch just as you said, my bad. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
