On Thu, Feb 26, 2015 at 06:02:11PM +0800, Peter Hung wrote: > This patch implement relative MCR/MSR function, such like > tiocmget()/tiocmset()/dtr_rts()/carrier_raised() > > original f81232_carrier_raised() compared with wrong value UART_DCD. > It's should compared with UART_MSR_DCD. > > Signed-off-by: Peter Hung <hpeter+linux_ker...@gmail.com> > --- > drivers/usb/serial/f81232.c | 139 > +++++++++++++++++++++++++++++++++++++------- > 1 file changed, 117 insertions(+), 22 deletions(-)
> +static int f81232_set_mctrl(struct usb_serial_port *port, > + unsigned int set, unsigned int clear) > +{ > + u8 urb_value; Minor nit: could you just call this "val" as it's unrelated to any urb. Also looks good otherwise. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html