On Thu, 30 Apr 2015, Greg Kroah-Hartman wrote: > We should not be doing assignments within an if () block > so fix up the code to not do this. > > change was created using Coccinelle. > > CC: Alan Stern <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > --- > drivers/usb/host/ehci-dbg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c > index 524cbf26d992..b26b96e25a13 100644 > --- a/drivers/usb/host/ehci-dbg.c > +++ b/drivers/usb/host/ehci-dbg.c > @@ -628,7 +628,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer > *buf) > unsigned i; > __hc32 tag; > > - if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC))) > + seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC); > + if (!seen) > return 0; > seen_count = 0;
For this and all the other patches under my bailiwick: Acked-by: Alan Stern <[email protected]> Although some people might wish that "sizeof *seen" had been replaced by "sizeof(*seen)". Also, in patch 11/19, doesn't checkpatch complain about the extra space in this new line? > + if (! ed) BTW, isn't this sort of thing generally relegated to kernel-janitors? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
