On Wed, Sep 09, 2015 at 09:04:55AM -0500, Bin Liu wrote:
> Hi,
> 
> On 09/09/2015 08:56 AM, Sergei Shtylyov wrote:
> >Hello.
> >
> >On 9/9/2015 4:37 PM, Bin Liu wrote:
> >
> >>Set musb config->maximum_speed based on the dts setting to control musb
> >>speed.
> >>
> >>By default musb works in high-speed mode. Adding
> >>
> >>    maximum-speed = "full-speed";
> >>
> >>to dts usb node will force musb to full-speed mode.
> >>
> >>Signed-off-by: Bin Liu <b-...@ti.com>
> >>---
> >>  drivers/usb/musb/musb_dsps.c | 14 ++++++++++++++
> >>  1 file changed, 14 insertions(+)
> >>
> >>diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> >>index 65d931a..8c4b064 100644
> >>--- a/drivers/usb/musb/musb_dsps.c
> >>+++ b/drivers/usb/musb/musb_dsps.c
> >>@@ -744,6 +744,20 @@ static int dsps_create_musb_pdev(struct dsps_glue
> >>*glue,
> >>      if (!ret && val)
> >>          config->multipoint = true;
> >>
> >>+    config->maximum_speed = of_usb_get_maximum_speed(dn);
> >>+    switch (config->maximum_speed) {
> >>+    case USB_SPEED_LOW:
> >>+        /* fall */
> >
> >    No need for this line.
> 
> Sure, I will remove it.
> 
> >
> >>+    case USB_SPEED_FULL:
> >>+        break;
> >>+    case USB_SPEED_SUPER:
> >>+        dev_warn(dev, "ignore incorrect maximum_speed "
> >>+                "(super-speed) setting in dts");
> >>+        /* fall */
> >
> >    Fall thru.
> 
> Will do.
> 
> Do I have to re-send patch 1/2 in v3, since it is not revised? I am not sure
> about the general rules in patch submission.

just reply to this email with new version of $subject.

-- 
balbi

Attachment: signature.asc
Description: Digital signature

Reply via email to