On 12/17/2015 2:49 PM, Marek Vasut wrote: > The "enumspd" field is located in register DSTS[2:1], but the current > set of macros define the possible values without the necessary offset. > This in turn causes incorrect detection of gadget link partner speed > in dwc2_hsotg_irq_enumdone() . > > The rest of the macros in dwc2/hw.h always define possible values of > fields with offset, so keep this consistent, add the necessary offset > and fix the problem with speed detection.
Looks like only single bits are shifted and bitfields define a SHIFT and MASK using unshifted values. Could you use the existing DSTS_ENUMSPD_SHIFT macro at the place of use. Less changes that way too. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
