On 12/17/2015 6:26 PM, Marek Vasut wrote: > The "enumspd" field is located in register DSTS[2:1], but the code > which checks the bitfield does not shift the value accordingly. This > in turn causes incorrect detection of gadget link partner speed in > dwc2_hsotg_irq_enumdone() . > > Shift the value accordingly to fix the problem with speed detection. > > Signed-off-by: Marek Vasut <[email protected]> > Cc: Felipe Balbi <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: John Youn <[email protected]> > --- > drivers/usb/dwc2/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > V2: - Modify the code itself by adding the necessary shift instead of > modifying the header. > - Update commit message. > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index 0abf73c..48e47c1 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2095,7 +2095,7 @@ static void dwc2_hsotg_irq_enumdone(struct dwc2_hsotg > *hsotg) > */ > > /* catch both EnumSpd_FS and EnumSpd_FS48 */ > - switch (dsts & DSTS_ENUMSPD_MASK) { > + switch ((dsts & DSTS_ENUMSPD_MASK) >> DSTS_ENUMSPD_SHIFT) { > case DSTS_ENUMSPD_FS: > case DSTS_ENUMSPD_FS48: > hsotg->gadget.speed = USB_SPEED_FULL; >
Acked-by: John Youn <[email protected]> John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
