> -----Original Message-----
> From: Valentin Yakovenkov [mailto:[email protected]]
> Sent: Wednesday, March 23, 2016 11:52
> To: Konstantin Shkolnyy; [email protected]
> Subject: Re: [PATCH] Add DCD line support to CP210x driver
>
> Here's regenerated patch against latest usb-serial tree.
[...]
> @@ -533,6 +547,11 @@ static int cp210x_open(struct tty_struct *tty, struct
> usb_serial_port *port)
> {
> int result;
>
> + struct usb_serial *serial = port->serial;
> + struct cp210x_port_private *spriv = usb_get_serial_data(serial);
> +
> + spriv->rx_state = CP210X_STATE_IDLE;
> +
> result = cp210x_set_config_single(port, CP210X_IFC_ENABLE,
This call to cp210x_set_config_single tells me that it's not against the proper
branch. This function was replaced with cp210x_write_u16_reg just recently.
When I use these commands:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
cd usb-serial
git checkout usb-next
git log
I get:
commit 7084fa868b509646fa30773d5d3ef4f26a62eb6f
Author: Konstantin Shkolnyy <[email protected]>
Date: Sun Feb 28 15:51:56 2016 -0600
USB: serial: cp210x: add new access functions for large registers
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy <[email protected]>
[johan: minor style change ]
Signed-off-by: Johan Hovold <[email protected]>
