On 04/06/2016 08:10 PM, Johan Hovold wrote: > As Joe already said, we generally don't want indentation-only changes to > existing code. Just try to stick to the style of the driver (even if > it's inconsistent at times). >
Hm, I don't get it. I understand that white-space-only changes are discouraged if they are freestanding and contributors don't follow up with any change to functionality (as outlined in development-process/4.Coding), but this is not the case here. IMHO, if the style of a module is inconsistent, it should be fixed at some point. The kind of policy you are presenting here will in the long run lead to messy code, and can't be found in any of the official documents (e.g. CodingStyle, SubmitChecklist, development-process/) either. It also encourages mixing white-space changes with patches that change functionality, which is a bad practice. I'll just drop the indentation changes. The rest is fine, I guess? Grigori
signature.asc
Description: OpenPGP digital signature
