Hi, Krzysztof Opasiak <[email protected]> writes: > From: Igor Kotrasinski <[email protected]> > > Add endpoints definitions and ops for both endpoints and gadget. > Add also a suitable platform driver and functions for handling > usbip events. > > This commit is a result of cooperation between Samsung R&D Institute > Poland and Open Operating Systems Student Society at University > of Warsaw (O2S3@UW) consisting of: > > Igor Kotrasinski <[email protected]> > Karol Kosik <[email protected]> > Ewelina Kosmider <[email protected]> > Dawid Lazarczyk <[email protected]> > Piotr Szulc <[email protected]> > > Tutor and project owner: > Krzysztof Opasiak <[email protected]> > > Signed-off-by: Igor Kotrasinski <[email protected]> > Signed-off-by: Karol Kosik <[email protected]> > [Various bug fixes, improvements and commit msg update] > Signed-off-by: Krzysztof Opasiak <[email protected]>
just a couple minor nits below. Nice work
> +struct vep *find_endpoint(struct vudc *udc, u8 address)
polluting namespace. Care to add 'static'?
> +static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req)
> +{
> + struct vrequest *req;
> +
> + if (!_ep || !_req) {
> + WARN_ON(1);
> + return;
> + }
if (WARN_ON(!_ep || !_req))
return;
--
balbi
signature.asc
Description: PGP signature
