Hi, Dan Carpenter <[email protected]> writes: > In the original DWC3_DCFG_NUMP() was always zero. It looks like the > intent was to shift first and then do the mask. > > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculation of ACK > TP NUMP') > Signed-off-by: Dan Carpenter <[email protected]>
Thanks for this fix, I completely missed it :-) Greg, if you want to take this as a patch, that's fine by me. Otherwise I can queue it for -rc1. In any case, S-o-B below: Signed-off-by: Felipe Balbi <[email protected]> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 186a886..7ddf944 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -277,7 +277,7 @@ > #define DWC3_DCFG_FULLSPEED1 (3 << 0) > > #define DWC3_DCFG_NUMP_SHIFT 17 > -#define DWC3_DCFG_NUMP(n) (((n) & 0x1f) >> DWC3_DCFG_NUMP_SHIFT) > +#define DWC3_DCFG_NUMP(n) (((n) >> DWC3_DCFG_NUMP_SHIFT) & 0x1f) > #define DWC3_DCFG_NUMP_MASK (0x1f << DWC3_DCFG_NUMP_SHIFT) > #define DWC3_DCFG_LPM_CAP (1 << 22) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- balbi
signature.asc
Description: PGP signature
