> -----Original Message-----
> From: Felipe Balbi [mailto:[email protected]]
> Sent: Wednesday, May 04, 2016 1:28 PM
> To: Rajesh Bhagat <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Yang-Leo Li
> <[email protected]>; Sriram Dash <[email protected]>; Rajesh Bhagat
> <[email protected]>
> Subject: Re: [PATCH] drivers: usb: dwc3 : Configure DMA properties and ops 
> from DT
> 
> 
> Hi,
> 
> Rajesh Bhagat <[email protected]> writes:
> > On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly
> > set to be able to do DMA allocations, so use the of_dma_configure()
> > helper to populate the dma properties and assign an appropriate dma_ops.
> >
> > Signed-off-by: Rajesh Bhagat <[email protected]>
> > Reviewed-by: Yang-Leo Li <[email protected]>

Hi,

> 
> Cool, nxp is also using dwc3 :-) C'mon Rajesh, send us a glue layer :)
> 

I would surely be sending the glue layer soon :)

> > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index
> > c679f63..4d5b783 100644
> > --- a/drivers/usb/dwc3/host.c
> > +++ b/drivers/usb/dwc3/host.c
> > @@ -17,6 +17,7 @@
> >
> >  #include <linux/platform_device.h>
> >  #include <linux/usb/xhci_pdriver.h>
> > +#include <linux/of_device.h>
> >
> >  #include "core.h"
> >
> > @@ -32,6 +33,9 @@ int dwc3_host_init(struct dwc3 *dwc)
> >             return -ENOMEM;
> >     }
> >
> > +   if (IS_ENABLED(CONFIG_OF) && dwc->dev->of_node)
> > +           of_dma_configure(&xhci->dev, dwc->dev->of_node);
> 
> okay, so we have a long discussion about this going on. You can catch up with 
> it
> starting here:
> 
> http://marc.info/[email protected]
> 
> At least for now, this patch will be applied. We need to have a better 
> solution for this,
> one that helps not only DT platforms.
> 

Thanks for information. 

> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to