Hi, fengguang,
ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input,
- sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
+ sizeof(*input), HID_FEATURE_REPORT,
+ HID_REQ_SET_REPORT);
I tested this code, but our device cannot work on it.
So, I think we should modify the code as below.
ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input,
sizeof(u8)*U1_FEATURE_REPORT_LEN,
HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
Best Regards,
Masaki Ota
-----Original Message-----
From: kbuild test robot [mailto:[email protected]]
Sent: Saturday, June 18, 2016 9:13 PM
Cc: [email protected]; [email protected]; [email protected];
Jiri Kosina; 太田 真喜 Masaki Ota
Subject: [PATCH] HID: fix noderef.cocci warnings
drivers/hid/hid-alps.c:139:3-9: ERROR: application of sizeof to pointer
drivers/hid/hid-alps.c:148:4-10: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of the
pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
CC: Masaki Ota <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---
hid-alps.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -136,7 +136,8 @@ static int u1_read_write_register(struct
input[7] = check_sum;
ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input,
- sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
+ sizeof(*input), HID_FEATURE_REPORT,
+ HID_REQ_SET_REPORT);
if (ret < 0) {
dev_err(&hdev->dev, "failed to read command (%d)\n", ret); @@
-145,7 +146,7 @@ static int u1_read_write_register(struct
if (read_flag) {
ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, readbuf,
- sizeof(readbuf), HID_FEATURE_REPORT,
+ sizeof(*readbuf), HID_FEATURE_REPORT,
HID_REQ_GET_REPORT);
if (ret < 0) {
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
