Hi,
> -----Original Message-----
> From: Peter Chen [mailto:[email protected]]
> Sent: Friday, July 15, 2016 3:02 PM
> To: Jun Li <[email protected]>
> Cc: Peter Chen <[email protected]>; [email protected]
> Subject: Re: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity
> for imx6 and imx7
> 
> On Tue, Jul 12, 2016 at 03:24:49PM +0800, Li Jun wrote:
> > As all usb power supply use low active for over current flag on imx6
> > imx7 boards, and the default register setting(0) is for high active,
> > this patch is to correct it.
> >
> 
> We may can't ensure all USB power switch chips work like that, I suggest
> you making this as default.
> 
> I will change the commit log like below if you are ok.
> 
> As most of all usb power switch chips use active-low for over current flag,
> but the default register setting(0) is for active-high at imx6/imx7, this
> patch changes default value as active-low.

Looks better, I am okay with it except a tiny comment
:%s/As most of all usb power/As most of usb power

Li Jun
> 
> > Signed-off-by: Li Jun <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to