Hi, John Youn <john.y...@synopsys.com> writes: > On 8/8/2016 1:30 PM, Felipe F. Tonello wrote: >> Use gadget's framework allocation function instead of directly calling >> usb_ep_alloc_request(). >> >> Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> >> --- >> drivers/usb/gadget/function/f_hid.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/usb/gadget/function/f_hid.c >> b/drivers/usb/gadget/function/f_hid.c >> index a010496e4e05..89d2e9a5a04f 100644 >> --- a/drivers/usb/gadget/function/f_hid.c >> +++ b/drivers/usb/gadget/function/f_hid.c >> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, >> struct usb_function *f) >> >> /* preallocate request and buffer */ >> status = -ENOMEM; >> - hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL); >> + hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length); >> if (!hidg->req) >> goto fail; >> >> - hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL); >> - if (!hidg->req->buf) >> - goto fail; >> - >> /* set descriptor dynamic values */ >> hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass; >> hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol; >> > > Hi Felipe, > > This commit on your testing/next breaks compilation. > > ../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’: > ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to > function ‘alloc_ep_req’ > hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length); > ^ > In file included from ../drivers/usb/gadget/function/f_hid.c:24:0: > ../drivers/usb/gadget/u_f.h:63:21: note: declared here > struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int > default_len);
true that :-) Dropping from my queue. -- balbi
signature.asc
Description: PGP signature
