-----BEGIN PGP SIGNED MESSAGE-----
Hello Ulf and Alan,
On Thu, 2016-09-15 at 10:16 -0400, Alan Stern wrote:
> > ---
> > drivers/mmc/host/rtsx_usb_sdmmc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> > diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c
> > b/drivers/mmc/host/rtsx_usb_sdmmc.c
> > index 6c71fc9..a59c7fa 100644
> > --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> > +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> > @@ -1314,6 +1314,7 @@ static void rtsx_usb_update_led(struct work_struct
> > container_of(work, struct rtsx_usb_sdmmc, led_work);
> > struct rtsx_ucr *ucr = host->ucr;
> > + pm_runtime_get_sync(sdmmc_dev(host));
> > mutex_lock(&ucr->dev_mutex);
> > if (host->led.brightness == LED_OFF)
> > @@ -1322,6 +1323,7 @@ static void rtsx_usb_update_led(struct work_struct
> > rtsx_usb_turn_on_led(ucr);
> > mutex_unlock(&ucr->dev_mutex);
> > + pm_runtime_put(sdmmc_dev(host));
> > }
> > #endif
> > --
> > Although, I doubt the above is the main reason to the issues we see.
> I don't know -- it could well be the reason. The symptoms are
> definitely what you would expect to see if some thread was doing I/O
> without calling the pm_runtime_* routines.
> > Instead I think somehow the parent device (usb device) isn't being
> > properly managed through runtime PM, but not due to wrong deployment
> > in the mmc core nor in the rtsx_usb_driver, but at some place else.
> > :-)
> > I started looking for calls to pm_suspend_ignore_children(dev, true),
> > which would decouple the usb device from the mmc platform device from
> > a runtime PM point of view. I found one suspicious case!
> > drivers/usb/storage/realtek_cr.c:
> > pm_suspend_ignore_children(&us->pusb_intf->dev, true);
> > As I am not so familiar with USB, I can't really tell why the above
> > exists, although perhaps just removing that line would be worth a
> > try!?
> No, the realtek_cr driver has no connection with this. It's a
> sub-module of the usb_storage driver; it uses the SCSI interface,
> not the MMC interface.
> > If neither of the above works, the next step could be to start
> > checking error codes in the mmc core and in the rtsx_usb_sdmmc driver,
> > from the calls to pm_runtime_get|put() and pm_runtime_enable().
> Let's see what this patch does.
I was able to hit it again. Please find the usbmon trace at:
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."
-----BEGIN PGP SIGNATURE-----
-----END PGP SIGNATURE-----
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html