Hi,

On Thu, Sep 22, 2016 at 02:19:00PM +0300, Hans de Goede wrote:
> The musb-core now a days always treats babble errors in host mode

I don't think this statement is accurate. You might want to change it to
"The musb core already handles babble interrupt" or something else.

Regards,
-Bin.

> as disconnects, so there is no need for the sunxi specific handling
> of this anymore.
> 
> Signed-off-by: Hans de Goede <hdego...@redhat.com>
> ---
> Changes in v2:
> -This is a new patch in v2 of this patch series
> ---
>  drivers/usb/musb/sunxi.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 1408245..82eba92 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -186,16 +186,6 @@ static irqreturn_t sunxi_musb_interrupt(int irq, void 
> *__hci)
>       if (musb->int_usb)
>               writeb(musb->int_usb, musb->mregs + SUNXI_MUSB_INTRUSB);
>  
> -     /*
> -      * sunxi musb often signals babble on low / full speed device
> -      * disconnect, without ever raising MUSB_INTR_DISCONNECT, since
> -      * normally babble never happens treat it as disconnect.
> -      */
> -     if ((musb->int_usb & MUSB_INTR_BABBLE) && is_host_active(musb)) {
> -             musb->int_usb &= ~MUSB_INTR_BABBLE;
> -             musb->int_usb |= MUSB_INTR_DISCONNECT;
> -     }
> -
>       if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
>               /* ep0 FADDR must be 0 when (re)entering peripheral mode */
>               musb_ep_select(musb->mregs, 0);
> -- 
> 2.9.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to