On Wed, Sep 28, 2016 at 04:05:48PM +0300, Felipe Balbi wrote:
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Signed-off-by: Felipe Balbi <[email protected]>
> ---
> drivers/usb/gadget/udc/net2280.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/net2280.c
> b/drivers/usb/gadget/udc/net2280.c
> index 61c938c36d88..85504419ab31 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -224,14 +224,14 @@ net2280_enable(struct usb_ep *_ep, const struct
> usb_endpoint_descriptor *desc)
> }
>
> /* sanity check ep-e/ep-f since their fifos are small */
> - max = usb_endpoint_maxp(desc) & 0x1fff;
> + max = usb_endpoint_maxp(desc);
The mask is 0x1fff, which keeps bit 11 & 12.
> if (ep->num > 4 && max > 64 && (dev->quirks & PLX_LEGACY)) {
> ret = -ERANGE;
> goto print_err;
> }
>
> spin_lock_irqsave(&dev->lock, flags);
> - _ep->maxpacket = max & 0x7ff;
> + _ep->maxpacket = max;
> ep->desc = desc;
>
> /* ep_reset() has already been called */
> @@ -1839,7 +1839,7 @@ static ssize_t queues_show(struct device *_dev, struct
> device_attribute *attr,
> ep->ep.name, t & USB_ENDPOINT_NUMBER_MASK,
> (t & USB_DIR_IN) ? "in" : "out",
> type_string(d->bmAttributes),
> - usb_endpoint_maxp(d) & 0x1fff,
> + usb_endpoint_maxp(d),
The same here.
Regards,
-Bin.
> ep->dma ? "dma" : "pio", ep->fifo_size
> );
> } else /* ep0 should only have one transfer queued */
> --
> 2.10.0.440.g21f862b
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
