Hi, Baolin Wang <baolin.w...@linaro.org> writes: >> Baolin Wang <baolin.w...@linaro.org> writes: >>> When we change the USB function with configfs dynamically, we possibly met >>> this >>> situation: one core is doing the control transfer, another core is trying to >>> unregister the USB gadget from userspace, we must wait for completing this >>> control tranfer, or it will hang the controller to set the DEVCTRLHLT flag. >>> >>> Signed-off-by: Baolin Wang <baolin.w...@linaro.org> >> >> Can you make sure this still works? > > With applying this patch, It can work well on my platform, but I have > some worries about the risk of accessing 'dwc->ep0state' without lock > protection in dwc3_gadget_pullup() function.
hmm, I might be missing something, but I think there's no risk here. If anything, a wmb() is probably enough before reading ep0state. No? -- balbi
Description: PGP signature