On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote:
> On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote:
> > Hi Oliver,
>
> > Device operates normally after reconnect. So it seems you were right,
> > there's no handling for EPIPE and EPROTO errors reported to
> > acm_read_bulk_callback.
> > Following patch fixes it for me, if it looks okay for you, I'll resend it
> > properly.
>
> Hi,
>
> I am afraid we cannot just ignore or report -EPIPE.
> We need to clear a halt. Maybe your device would work
> if there were a delay in communication before the halt
> is cleared. I am not sure your patch is the right thing
> to do in all cases.
>
> Regards
> Oliver
Hi Oliver,
now I'm really confused. Just looked at drivers/usb/serial/generic.c
which just stops submitting urbs on -EPIPE. On contrary
drivers/usb/serial/ti_usb_3410_5052.c does just the opposite.
I'm assuming generic function does it right, but what do you
mean by "clearing a halt"?
regards,
ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
