* Ladislav Michl <[email protected]> [161108 06:39]:
> Hi Tony,
>
> On Mon, Nov 07, 2016 at 02:50:16PM -0700, Tony Lindgren wrote:
> > Hi all,
> >
> > Here are musb fixes for the issues that I've been able to track down.
> > Not sure if these will help with the problem Ladis was seeing as I'm
> > not able to reproduce that one it seems.
>
> I still need 87326e858448c40e32f142c0b8dcc59d7b27c641 (usb: musb: Remove
> extra PM runtime calls from 2430 glue layer) reverted, but I'm happy with
> that solution so far.
Weird, I have not figured out what happens there..
The only thing I'm still wondering about is if phy-twl4030-usb.c
is losing ID pin interrupts occasionally but have not been
able to verify that. Maybe try the following additional patch
and see if it makes any difference?
Regards,
Tony
8< --------------
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -304,6 +304,17 @@ static enum musb_vbus_id_status
status &= ~BIT(7);
else
twl->vbus_supplied = true;
+
+ /* Recheck status again for ID pin */
+ if (!(status & BIT(2))) {
+ msleep(200);
+ status = twl4030_readb(twl,
+ TWL_MODULE_PM_MASTER,
+ STS_HW_CONDITIONS);
+ if (status < 0)
+ dev_err(twl->dev, "USB link status err
%d\n",
+ status);
+ }
}
if (status & BIT(2))
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
