On Mon, Mar 20, 2017 at 10:12:55AM -0400, Alan Stern wrote:
> > @@ -2063,12 +2063,11 @@ static int dummy_hub_control(
> > break;
> > case USB_PORT_FEAT_POWER:
> > if (hcd->speed == HCD_USB3) {
> > - if (dum_hcd->port_status & USB_PORT_STAT_POWER)
> > + if (dum_hcd->port_status &
> > USB_SS_PORT_STAT_POWER)
> > dev_dbg(dummy_dev(dum_hcd),
> > "power-off\n");
> > } else
> > - if (dum_hcd->port_status &
> > - USB_SS_PORT_STAT_POWER)
> > + if (dum_hcd->port_status & USB_PORT_STAT_POWER)
> > dev_dbg(dummy_dev(dum_hcd),
> > "power-off\n");
> > /* FALLS THROUGH */
>
> This certainly is not a complete fix. Compare the code here with the
> code for the SetPortFeature case. For one speed we need to set the
> USB_PORT_STAT_POWER bit and for the other speed we need to set the
> USB_SS_PORT_STAT_POWER bit in dum_hcd->port_status. 1 << wValue cannot
> be the correct bit in both cases.
It depends on whether wValue can reflect the two HCDs, and if not, it looks
like a bigger problem.
And an additional selector is needed?
#define USB_PORT_FEAT_POWER_SS 9
Thanks,
Yuyang
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
