Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated
since v2.1.69 and has been broken for all tty drivers but serial-core
since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting
speed via SPD_*") without anyone noticing (for four years).Instead of reverting the offending commit, lets get rid of this legacy code while adding back a warning about the SPD flags being deprecated to the drivers that once implemented it. Note that drivers implementing SPD_CUST will continue to support using a custom divisor. Also note that serial-core did not rely on the TTY layer for SPD handling and continues to support it while warning about deprecation (since 2003 at least). Greg, I suggest you take it all trough the TTY tree even if merging through multiple trees and applying the final patch once everything is upstream would be an option. Also the irda clean up does not depend on the rest of series as the code implementing SPD handling was ifdefed out. Johan Johan Hovold (9): serial: rate limit custom-speed deprecation notice USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic USB: serial: ftdi_sio: remove broken alt-speed handling tty: simserial: drop unused alt_speed handling tty: amiserial: drop broken alt-speed support tty: cyclades: drop broken alt-speed support tty: rocket: drop broken alt-speed support tty: ircomm: remove dead and broken ioctl code tty: drop unused alt_speed from tty_struct arch/ia64/hp/sim/simserial.c | 13 ----- drivers/tty/amiserial.c | 23 ++------ drivers/tty/cyclades.c | 21 ++++---- drivers/tty/rocket.c | 27 +++------- drivers/tty/serial/serial_core.c | 5 +- drivers/usb/serial/ftdi_sio.c | 67 +++++------------------ include/linux/tty.h | 1 - net/irda/ircomm/ircomm_tty_ioctl.c | 107 +------------------------------------ 8 files changed, 34 insertions(+), 230 deletions(-) -- 2.13.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
