On Mon, Jul 17, 2017 at 03:19:10PM +0000, Schoon, Michael wrote:
>     Please add support for HP TD620 Linear Display device to the pl2303 
> module.  The USB Device ID is 03f0:0956 for this 2x20 display.
>     
>     Changes to be committed:
>         modified:   drivers/usb/serial/pl2303.c
>         modified:   drivers/usb/serial/pl2303.h
>     

Intersting indentation :(

Also, what is this "Changes to be..." line for?

And finally, did you run this through scripts/checkpatch.pl?

>     --- drivers/usb/serial/pl2303.c     2017-07-14 13:16:27.928149225 -0500
>     +++ drivers/usb/serial/pl2303.c.orig        2017-07-14 13:43:59.029860481 
> -0500
>     @@ -92,7 +92,6 @@ static const struct usb_device_id id_tab
>         { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
>         { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
>         { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
>     -   { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },

Well, now finally, your patch is backwards and whitespace damaged,
making it impossible to apply :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to