Hi Greg, Thank you for the patch.
On Wednesday 19 Jul 2017 14:17:39 Greg Kroah-Hartman wrote: > MODULE_VERSION is useless for in-kernel drivers, so just remove all > usage of it in the USB gadget drivers. Along with this, some > DRIVER_VERSION macros were removed as they are also pointless. > > Cc: Laurent Pinchart <[email protected]> > Cc: Felipe Balbi <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > --- > drivers/usb/gadget/legacy/webcam.c | 1 - Reviewed-by: Laurent Pinchart <[email protected]> > drivers/usb/gadget/udc/mv_udc_core.c | 2 -- > drivers/usb/gadget/udc/s3c2410_udc.c | 4 +--- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/gadget/legacy/webcam.c > b/drivers/usb/gadget/legacy/webcam.c index f9661cd627c8..82c13fce9232 > 100644 > --- a/drivers/usb/gadget/legacy/webcam.c > +++ b/drivers/usb/gadget/legacy/webcam.c > @@ -436,5 +436,4 @@ module_usb_composite_driver(webcam_driver); > MODULE_AUTHOR("Laurent Pinchart"); > MODULE_DESCRIPTION("Webcam Video Gadget"); > MODULE_LICENSE("GPL"); > -MODULE_VERSION("0.1.0"); > > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c > b/drivers/usb/gadget/udc/mv_udc_core.c index 8a708d0a1042..4103bf7cf52a > 100644 > --- a/drivers/usb/gadget/udc/mv_udc_core.c > +++ b/drivers/usb/gadget/udc/mv_udc_core.c > @@ -39,7 +39,6 @@ > #include "mv_udc.h" > > #define DRIVER_DESC "Marvell PXA USB Device Controller driver" > -#define DRIVER_VERSION "8 Nov 2010" > > #define ep_dir(ep) (((ep)->ep_num == 0) ? \ > ((ep)->udc->ep0_dir) : ((ep)->direction)) > @@ -2427,5 +2426,4 @@ module_platform_driver(udc_driver); > MODULE_ALIAS("platform:mv-udc"); > MODULE_DESCRIPTION(DRIVER_DESC); > MODULE_AUTHOR("Chao Xie <[email protected]>"); > -MODULE_VERSION(DRIVER_VERSION); > MODULE_LICENSE("GPL"); > diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c > b/drivers/usb/gadget/udc/s3c2410_udc.c index 4643a01262b4..394abd5d65c0 > 100644 > --- a/drivers/usb/gadget/udc/s3c2410_udc.c > +++ b/drivers/usb/gadget/udc/s3c2410_udc.c > @@ -51,7 +51,6 @@ > #include "s3c2410_udc.h" > > #define DRIVER_DESC "S3C2410 USB Device Controller Gadget" > -#define DRIVER_VERSION "29 Apr 2007" > #define DRIVER_AUTHOR "Herbert Pötzl <[email protected]>, " \ > "Arnaud Patard <[email protected]>" > > @@ -1996,7 +1995,7 @@ static int __init udc_init(void) > { > int retval; > > - dprintk(DEBUG_NORMAL, "%s: version %s\n", gadget_name, DRIVER_VERSION); > + dprintk(DEBUG_NORMAL, "%s\n", gadget_name); > > s3c2410_udc_debugfs_root = debugfs_create_dir(gadget_name, NULL); > if (IS_ERR(s3c2410_udc_debugfs_root)) { > @@ -2027,5 +2026,4 @@ module_exit(udc_exit); > > MODULE_AUTHOR(DRIVER_AUTHOR); > MODULE_DESCRIPTION(DRIVER_DESC); > -MODULE_VERSION(DRIVER_VERSION); > MODULE_LICENSE("GPL"); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
