On 08/15/2017 12:12 PM, Sergei Shtylyov wrote: > Hello! > > On 8/13/2017 3:04 PM, Alexandre Bailon wrote: > >> The DA8xx and DSPS platforms don't use the same address for few >> registers. >> On Da8xx, this is causing some issues (e.g. teardown that doesn't work). >> Configure the address of the register during the init and use them >> instead >> of constants. >> >> Reported-by: [email protected] >> Signed-off-by: Alexandre Bailon <[email protected]> >> --- >> drivers/usb/musb/musb_cppi41.c | 23 +++++++++++++++++++---- >> 1 file changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/musb/musb_cppi41.c >> b/drivers/usb/musb/musb_cppi41.c >> index ba255280a624..dbff0e0a4ff5 100644 >> --- a/drivers/usb/musb/musb_cppi41.c >> +++ b/drivers/usb/musb/musb_cppi41.c >> @@ -26,6 +26,9 @@ >> #define MUSB_DMA_NUM_CHANNELS 15 >> +#define DA8XX_USB_AUTOREQ_REG 0x14 >> +#define DA8XX_USB_TEARDOWN_REG 0x1c > > Why these _REG suffixes suddenly? I took these defines in da8xx.c. Actually, I think I should make a third patch to remove them from da8xx.c because they are not even used. > > [...] > > Other than that looks sane. Need my ACK? I don't know if that is needed but I guess it would be appreciated.
Best Regards, Alexandre > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
