On Fri, Dec 08, 2017 at 03:57:30PM +0100, Greg KH wrote: > On Fri, Dec 08, 2017 at 02:44:12PM +0000, Michael Drake wrote: > > On 08/12/17 14:27, Greg KH wrote: > > > On Fri, Dec 08, 2017 at 10:30:43AM +0000, Michael Drake wrote: > > > > On 07/12/17 20:04, Greg KH wrote: > > > > > > > --- lsusb-v.orig 2017-12-07 21:01:26.153185002 +0100 > > > > > +++ lsusb-v.new 2017-12-07 21:01:32.806517978 +0100 > > > > > @@ -1110,9 +1110,9 @@ > > > > > bDescriptorType 36 > > > > > bDescriptorSubtype 1 (HEADER) > > > > > bcdADC 1.00 > > > > > - wTotalLength 0x0028 > > > > > + wTotalLength 40 > > > > [snip] > > > > > > Anyway, since it's a 2 byte field the hex representation > > > > is expected here, and the actual value is the same. > > > > > > Yes, the value is the same, but all other wTotalLength fields exported > > > by lsusb are in decimal. Changing just this one feels odd to me. > > > > Yes, that's a good reason for wanting to change the other ones. > > > > [snip] > > > > > I'll look at moving those other wFields to be also in 0x0000 mode to > > > match up here. > > > > If you like I can work up a patch for that. I'd just be tweaking > > the old printfs to dump wFields with "0x%04x". > > > > I'm also thinking of porting more of the existing lsusb dumping > > to use the desc_dump() function, but that would have to be piece > > by piece, as I get time. > > I think moving more over to use desc_dump() is a better idea, let me see > if I can do one now to see how hard/easy it is...
I've just fixed up the wTotalLength fields for now, I've run out of time to work on this. If you want to convert more of the descriptor fields, that would be wonderful. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
