Hi Adam, Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20171214] [also build test ERROR on v4.15-rc4] [cannot apply to usb/usb-testing hwmon/hwmon-next v4.15-rc3 v4.15-rc2 v4.15-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656 config: i386-randconfig-x016-201751 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386 Note: the linux-review/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656 HEAD 79d2ed6a04117216910ac1dad566e86599a0bcf5 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_source_caps': >> drivers/usb/typec/tcpm.c:794:27: error: macro "PD_HEADER_LE" requires 6 >> arguments, but only 5 given port->message_id, 0); ^ >> drivers/usb/typec/tcpm.c:791:16: error: 'PD_HEADER_LE' undeclared (first use >> in this function) msg.header = PD_HEADER_LE(PD_CTRL_REJECT, ^~~~~~~~~~~~ drivers/usb/typec/tcpm.c:791:16: note: each undeclared identifier is reported only once for each function it appears in drivers/usb/typec/tcpm.c:800:24: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->nr_src_pdo); ^ drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_sink_caps': drivers/usb/typec/tcpm.c:819:27: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->message_id, 0); ^ drivers/usb/typec/tcpm.c:816:16: error: 'PD_HEADER_LE' undeclared (first use in this function) msg.header = PD_HEADER_LE(PD_CTRL_REJECT, ^~~~~~~~~~~~ drivers/usb/typec/tcpm.c:825:24: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->nr_snk_pdo); ^ drivers/usb/typec/tcpm.c: In function 'vdm_run_state_machine': drivers/usb/typec/tcpm.c:1190:41: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->message_id, port->vdo_count); ^ drivers/usb/typec/tcpm.c:1187:16: error: 'PD_HEADER_LE' undeclared (first use in this function) msg.header = PD_HEADER_LE(PD_DATA_VENDOR_DEF, ^~~~~~~~~~~~ drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_control': drivers/usb/typec/tcpm.c:1669:26: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->message_id, 0); ^ drivers/usb/typec/tcpm.c:1667:15: error: 'PD_HEADER_LE' undeclared (first use in this function) msg.header = PD_HEADER_LE(type, port->pwr_role, ^~~~~~~~~~~~ drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_request': drivers/usb/typec/tcpm.c:1946:26: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given port->message_id, 1); ^ drivers/usb/typec/tcpm.c:1943:15: error: 'PD_HEADER_LE' undeclared (first use in this function) msg.header = PD_HEADER_LE(PD_DATA_REQUEST, ^~~~~~~~~~~~ vim +/PD_HEADER_LE +794 drivers/usb/typec/tcpm.c f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 782 f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 783 static int tcpm_pd_send_source_caps(struct tcpm_port *port) f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 784 { f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 785 struct pd_message msg; f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 786 int i; f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 787 f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 788 memset(&msg, 0, sizeof(msg)); f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 789 if (!port->nr_src_pdo) { f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 790 /* No source capabilities defined, sink only */ f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @791 msg.header = PD_HEADER_LE(PD_CTRL_REJECT, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 792 port->pwr_role, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 793 port->data_role, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @794 port->message_id, 0); f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 795 } else { f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 796 msg.header = PD_HEADER_LE(PD_DATA_SOURCE_CAP, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 797 port->pwr_role, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 798 port->data_role, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 799 port->message_id, f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 800 port->nr_src_pdo); f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 801 } f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 802 for (i = 0; i < port->nr_src_pdo; i++) f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 803 msg.payload[i] = cpu_to_le32(port->src_pdo[i]); f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 804 f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 805 return tcpm_pd_transmit(port, TCPC_TX_SOP, &msg); f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 806 } f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 807 :::::: The code at line 794 was first introduced by commit :::::: f0690a25a140b853b1842fa80faf828601bb47e8 staging: typec: USB Type-C Port Manager (tcpm) :::::: TO: Guenter Roeck <gro...@chromium.org> :::::: CC: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
