On Thu, 18 Jan 2018, Ladislav Michl wrote: > Don't complain on -EPROBE_DEFER when no PHY found, the driver > probe will be retried later. > > Signed-off-by: Ladislav Michl <[email protected]> > Acked-by: Tony Lindgren <[email protected]> > Acked-by: Roger Quadros <[email protected]> > --- > Changes: > - v2: None, just added Tony's ack > - v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack
Although there's nothing wrong with making this change, people don't like to see character strings broken up just to avoid long lines. Can you redo the patch without breaking the error message string? Alan Stern > drivers/usb/host/ehci-omap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c > index 854b146a457d..fd6170962a1a 100644 > --- a/drivers/usb/host/ehci-omap.c > +++ b/drivers/usb/host/ehci-omap.c > @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device > *pdev) > continue; > > ret = PTR_ERR(phy); > - dev_err(dev, "Can't get PHY device for port %d: %d\n", > - i, ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Can't get PHY device for port " > + "%d: %d\n", i, ret); > goto err_phy; > } -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
