Set rx mode before calling netif_wake_queue() when linking on to avoid
the device missing the receiving packets.

The transmission may start after calling netif_wake_queue(), and the
packets of resopnse may reach before calling rtl8152_set_rx_mode()
which let the device could receive packets. Then, the packets of
response would be missed.

Signed-off-by: Hayes Wang <hayesw...@realtek.com>
---
 drivers/net/usb/r8152.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 756de9ea8d2e..958b2e8b90f6 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3795,11 +3795,12 @@ static void set_carrier(struct r8152 *tp)
        if (speed & LINK_STATUS) {
                if (!netif_carrier_ok(netdev)) {
                        tp->rtl_ops.enable(tp);
-                       set_bit(RTL8152_SET_RX_MODE, &tp->flags);
                        netif_stop_queue(netdev);
                        napi_disable(napi);
                        netif_carrier_on(netdev);
                        rtl_start_rx(tp);
+                       clear_bit(RTL8152_SET_RX_MODE, &tp->flags);
+                       _rtl8152_set_rx_mode(netdev);
                        napi_enable(&tp->napi);
                        netif_wake_queue(netdev);
                        netif_info(tp, link, netdev, "carrier on\n");
@@ -4259,7 +4260,7 @@ static int rtl8152_post_reset(struct usb_interface *intf)
                mutex_lock(&tp->control);
                tp->rtl_ops.enable(tp);
                rtl_start_rx(tp);
-               rtl8152_set_rx_mode(netdev);
+               _rtl8152_set_rx_mode(netdev);
                mutex_unlock(&tp->control);
        }
 
-- 
2.13.6

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to