On Thu, 2018-02-15 at 13:16 +0200, Felipe Balbi wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. >
Reviewed-by: Andy Shevchenko <[email protected]> Though one comment below. > Signed-off-by: Felipe Balbi <[email protected]> > static void dwc3_debugfs_create_endpoint_file(struct dwc3_ep *dep, > + struct dentry *parent, const char *const name, > + const struct file_operations *const fops) > { > + (void) debugfs_create_file(name, S_IRUGO, parent, dep, fops); > } At this point why do you need one line function anymore? > + dwc3_debugfs_create_endpoint_file(dep, parent, > + name, fops); -- Andy Shevchenko <[email protected]> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
