On linux-4.4 and linux-4.9 we get a warning about an array that is
never initialized when CONFIG_REGULATOR is disabled:

drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe':
drivers/usb/phy/phy-msm-usb.c:1911:14: error: 'regs[0].consumer' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
  motg->vddcx = regs[0].consumer;
drivers/usb/phy/phy-msm-usb.c:1912:14: error: 'regs[1].consumer' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
  motg->v3p3  = regs[1].consumer;
drivers/usb/phy/phy-msm-usb.c:1913:14: error: 'regs[2].consumer' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
  motg->v1p8  = regs[2].consumer;

This adds a Kconfig dependency for it. In newer kernels, the driver no
longer exists, so this is only needed for stable kernels.

Signed-off-by: Arnd Bergmann <a...@arndb.de>
 drivers/usb/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index b9c409a18faa..125cea1c3c8d 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -147,6 +147,7 @@ config USB_MSM_OTG
        depends on (USB || USB_GADGET) && (ARCH_QCOM || COMPILE_TEST)
        depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 
        depends on RESET_CONTROLLER
+       depends on REGULATOR
        depends on EXTCON
        select USB_PHY

To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to