The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
a no-op because of the & vs | typo.  This bug predates git and it was
only discovered using static analysis so it must not affect too many
people in real life.

Signed-off-by: Dan Carpenter <>
Not tested.

diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index 3e2474959735..7679fb583e41 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci 
*pxa_ohci, int mode)
                uhcrhda |= RH_A_NPS;
        case PMM_GLOBAL_MODE:
-               uhcrhda &= ~(RH_A_NPS & RH_A_PSM);
+               uhcrhda &= ~(RH_A_NPS | RH_A_PSM);
        case PMM_PERPORT_MODE:
                uhcrhda &= ~(RH_A_NPS);
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
More majordomo info at

Reply via email to