On Sun, 13 Oct 2002, Ilya Konstantinov wrote:
Dear Ilya,
Thanks a lot for 'fixing my patch' :-)
> I'm attaching a patch which complements Jungshik's original patch
> ( http://mail.nl.linux.org/linux-utf8/2002-03/msg00022.html )
> which made mkisofs use iconv instead of internal Unicode conversion
> tables.
>
> Jungshik's patch already worked well for 8-bit encodings, but it didn't
> account for UTF-8, which is a varying character length encoding. The
> attached patch modified joliet_strlen so that it'll return the
> correct target UCS-2 length.
>
> Without this patch, UTF-8 filenames containing non-Latin characters
> won't work on Windows. They would show in directory listings and be
> accessible by 8.3 names, but not by their long filenames. This patch
> remedies this problem.
Ahah, that's the cause. With my patch, I was able to burn a
CD with Korean filenames(in CP949 or EUC-KR which is also a multibyte
encoding like UTF-8) which Linux doesn't have any problem accessing(I
mounted it as a joliet CD-ROM instead of ISO9660) However, under MS
Windows, it has the very problem you mentioned that your patch solved.
> How do we go about merging this into the cdrtools package?
When I made a patch, I wrote to the maintainer of cdrtools,
but his response was not so positive. At first, he asked me whether
iconv(3) is available on any platform other than Solaris. After I replied
that iconv(3) is a standard API specified in Single Unix Spec and that
Glibc 2.2.x has had it for a few years and Bruno's implementation
of iconv(3) in libiconv is widely available and had been ported to
virtually all platforms, he didn't reply. He eventually wanted to move
onto a more generic format (for DVD and similar media) whose name is
currently escaping me. Anyway, I guess it's not a bad idea to give it
another try to make a case for your patch to him. Why don't you write
him with detailed explanation of what your patch does and
the wide availability of iconv(3) on multitude of platforms? The address
should be available in cdrtools document and web page.
Although it's desirable to fix things in as upstream as possible,
we may try to go around a bit and persuade various Linux distribution
builders to apply our patches to cdrtools shipped in their
distros. Engineers from RH, Mandrake, PLD and SuSE and perhaps other
distros are here Linux-UTF8 list. Could you pick up our patches
and apply it to cdrtools?
Jungshik
--
Linux-UTF8: i18n of Linux on all levels
Archive: http://mail.nl.linux.org/linux-utf8/
