On Tuesday 24 June 2008, Mauro Carvalho Chehab wrote:
> > > Can I enable more logging than setting the trace parameter to 0xfff?
> >
> > No without adding more printk's to the driver, which I encourage you to
> > do.
>
> This would be one advantage of having uvc driver using video_ioctl2. to see
> ioctl's it is just a matter of using debug=1. If you use debug=3, you'll
> also view all arguments of the ioctl.

That won't happen. Anyway, the UVC driver already prints out ioctl trace 
messages to the kernel if you set the trace parameter high enough. Gregor was 
asking for more debugging output than that.

> PS.: I'm still waiting for uvc patches for its kernel addition.

I've received all the feedback and review I'll probably get, so I'll send a 
new patch this week with the latest driver.

I've addressed some of your comments (such as not using enums at userspace 
interface). What is the rationale behind not having userspace and kernelspace 
APIs in a single .h file ? If I'm not mistaken kernel headers are stripped 
from their #ifdef __KERNEL__ sections but distributions anyway. It makes 
sense to have separate headers when they become big enough, but I don't think 
that's the case for a single driver like this one.

Cheers,

Laurent Pinchart
_______________________________________________
Linux-uvc-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel

Reply via email to