Hi Alexey, Thanks for the patch, and sorry for the late reply.
On Monday 21 November 2011 15:51:47 Alexey Fisher wrote: > Hi Laurent, > > here is my version of bug_report file for debugfs. > It include usb.id, dmi.system.product (for upsidedown report). And > stream specific information. I think it is good size for initial patch. > I near future i would like to add control call count and control error > rate to stats. And probably firs urb error number to report file. > I think it will be enough to provide needed info for troubleshooting. I got a couple of comments regarding both the purpose of the patch and its implementation. I'd like to discuss the purpose first. My understanding is that this new debugfs entry is meant to help diagnosing and debugging issues. This is a nice thing, but most of the debugging information (such as the USB VID:PID and the DMI information) can already be obtained using lsusb and dmidecode. Duplicating in debugfs information that is already available through other means isn't something I'm very fond of. Sure, dmidecode needs to be run as root, but if the user can't figure that out I don't think getting him to moutn debugfs will be a great success either :-) -- Regards, Laurent Pinchart _______________________________________________ Linux-uvc-devel mailing list Linux-uvc-devel@lists.berlios.de https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
