On Tue, Dec 09, 2014 at 12:37:15PM +0000, Opensource [Steve Twiss] wrote: > On 09 December 2014 11:23 Geert Uytterhoeven wrote: > [ ... ]
> > + ret = register_restart_handler(&wdt->restart_handler); > > + if (ret) > > + dev_err(wdt->da9063->dev, > > + "Failed to register restart handler (err = %d)\n", ret); > > (I guess this is intentional).. if the restart handler doesn't get > registered then > this problem is just ignored and not counted as a real error. > This makes sense, since one doesn't want the watchdog driver to fail loading just because the restart handler failed to register. One option might be to make the message dev_warn instead of dev_err, but that is really a nitpick. Reviewed-by: Guenter Roeck <[email protected]> Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
