2015-02-11 11:26 GMT+01:00 Dan Carpenter <[email protected]>: > "ret" should be signed for the error handling to work correctly. This > doesn't matter much in real life since mtk_wdt_set_timeout() always > succeeds. > > Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]> > > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > index a87f6df..938b987 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev) > u32 reg; > struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev); > void __iomem *wdt_base = mtk_wdt->wdt_base; > - u32 ret; > + int ret; > > ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout); > if (ret < 0) -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
