On Fri, Feb 20, 2015 at 11:45:44PM +0000, James Hogan wrote:
> The IMG PDC watchdog probe function calls pdc_wdt_stop() prior to
> watchdog_set_drvdata(), causing a NULL pointer dereference when
> pdc_wdt_stop() retrieves the struct pdc_wdt_dev pointer using
> watchdog_get_drvdata() and reads the register base address through it.
> 
> Fix by moving the watchdog_set_drvdata() call earlier, to where various
> other pdc_wdt->wdt_dev fields are initialised.
> 
> Fixes: 93937669e9b5 ("watchdog: ImgTec PDC Watchdog Timer Driver")
> Signed-off-by: James Hogan <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Ezequiel Garcia <[email protected]>
> Cc: Naidu Tellapati <[email protected]>
> Cc: Jude Abraham <[email protected]>
> Cc: [email protected]

Reviewed-by: Guenter Roeck <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to