On 07/23/2015 01:21 PM, Ezequiel Garcia wrote:
Commit c631f20068 ("watchdog: imgpdc: Add reboot support") introduced
a restart handler but forgot to unregister it on driver removal. Fix it.

Fixes: c631f20068 ("watchdog: imgpdc: Add reboot support")
Signed-off-by: Ezequiel Garcia <[email protected]>

Good catch. Looks good. Note that you should use a 12-character SHA 
(c631f2006836).

Reviewed-by: Guenter Roeck <[email protected]>

---
Build test only.

  drivers/watchdog/imgpdc_wdt.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/imgpdc_wdt.c b/drivers/watchdog/imgpdc_wdt.c
index 0f73621..15ab072 100644
--- a/drivers/watchdog/imgpdc_wdt.c
+++ b/drivers/watchdog/imgpdc_wdt.c
@@ -316,6 +316,7 @@ static int pdc_wdt_remove(struct platform_device *pdev)
  {
        struct pdc_wdt_dev *pdc_wdt = platform_get_drvdata(pdev);

+       unregister_restart_handler(&pdc_wdt->restart_handler);
        pdc_wdt_stop(&pdc_wdt->wdt_dev);
        watchdog_unregister_device(&pdc_wdt->wdt_dev);
        clk_disable_unprepare(pdc_wdt->wdt_clk);


--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to