On 08/06/2015 01:31 AM, Barry Song wrote:
From: William Wang <[email protected]>
This patch adds support for the new CSR atlas7 chips. prima2 and atlas7
are similar in chip design, but the register layout and flows have some
differences.
This patch puts the differences including register layout and operations
in dt private data, so that one driver can be compatible for two chips.
Signed-off-by: William Wang <[email protected]>
Signed-off-by: Guo Zeng <[email protected]>
Signed-off-by: Barry Song <[email protected]>
You are pretty much doubling the size of this driver (from 225 to 446 LOC).
I don't see the benefits of having a single driver, sorry. It just makes
it very difficult to maintain. Please make this a separate driver.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
