Hi Dan,
Sorry for the late reply.
On Tue, 2014-09-09 at 12:40 +0300, Dan Carpenter wrote:
> Hello Luciano Coelho,
>
> The patch 0ce04ce797f8: "iwlwifi: mvm: set the TX disable bit when
> doing a chanctx switch" from May 8, 2014, leads to the following
> static checker warning:
>
> drivers/net/wireless/iwlwifi/mvm/mac80211.c:2768
> __iwl_mvm_assign_vif_chanctx()
> warn: missing error code here? 'iwl_mvm_sta_from_staid_protected()'
> failed. 'ret' = '0'
>
> drivers/net/wireless/iwlwifi/mvm/mac80211.c
> 2761 if (vif->csa_active && vif->type == NL80211_IFTYPE_STATION) {
> 2762 struct iwl_mvm_sta *mvmsta;
> 2763
> 2764 mvmsta = iwl_mvm_sta_from_staid_protected(mvm,
> 2765
> mvmvif->ap_sta_id);
> 2766
> 2767 if (WARN_ON(!mvmsta))
> 2768 goto out;
>
> Did you want to set an error code here? I don't know the code well
> enough to say.
Good catch!
This gets fixed in another patch I implemented (that Emmanuel is
probably going to send out soon) where I move the code to another
function.
Since this should not really happen in normal cases, and since this will
be fixed very soon anyway, we could probably leave this patch as it is.
The patch that fixes this is called "iwlwifi: mvm: finalize on
post_switch instead of unassign" and you should see it coming soon to a
theater near you. ;)
Thanks for running your cool scripts! :)
--
Cheers,
Luca.
N�����r��y����b�X��ǧv�^�){.n�+����{��*ޕ�,�{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i
