Felix Fietkau wrote: > The "goto chip_reset" is a bit misleading, because it does not actually > issue a chip reset. Instead it is bypassing processing of other > interrupts and assumes that the tasklet will issue a chip reset.
Well, we kill interrupts and the tasklet sets ATH_OP_HW_RESET, so no more interrupts will be processed in ath_isr(), so this is a fair assumption. > In the case of RXORN this does not happen, so bypassing processing of > other interrupts will simply allow them to fire again. Even if RXORN > was triggering a reset, it is not critical enough to need the bypass > here. Wouldn't this be fixed by just processing RXORN in the tasklet, along with FATAL ? Or are you saying that RXORN doesn't need a chip reset in both edma/legacy, since the edma check has been dropped ? Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
